Document the Service source #3913
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
|
/cc @mloiseleur |
|
|
||
| ## Domain names | ||
|
|
||
| The domain names of the DNS entries created from a Service are sourced from the following places: |
There was a problem hiding this comment.
| The domain names of the DNS entries created from a Service are sourced from the following places: | |
| The domain names of the DNS entries created from a Service are sourced following this plan: |
There was a problem hiding this comment.
I don't think "plan" is quite the right word. It is an algorithm, not a proposal. It does specify the locations where the data are sourced, so "places" isn't too far off, though the items do describe the act of adding instead of the data being added.
docs/sources/service.md
Outdated
| `external-dns.alpha.kubernetes.io/internal-hostname` annotation. | ||
| This behavior is suppressed if the `--ignore-hostname-annotation` flag was specified. | ||
|
|
||
| * If no DNS entries were produced for a Service by the previous steps |
There was a problem hiding this comment.
| * If no DNS entries were produced for a Service by the previous steps | |
| 2. If no DNS entries were produced for a Service by the previous step |
There was a problem hiding this comment.
This isn't the only place where items in the list depend on previous items not producing outputs. If we're going to take this sort of order-dependency as requiring a numbered list, we should do it consistently.
Co-authored-by: Michel Loiseleur <[email protected]>
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johngmyers The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Description
Adds reference documentation for the service source.
Checklist