Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AWS API gateway endpoint zoneId mappings #3826

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Add AWS API gateway endpoint zoneId mappings #3826

merged 1 commit into from
Aug 23, 2023

Conversation

avi-08
Copy link
Contributor

@avi-08 avi-08 commented Jul 28, 2023

Description

  • Adds mappings for API gateway regional endpoints to Route 53 Hosted Zone IDs.
  • API gateway edge-optimized endpoints are served using CloudFront which has an existing mapping. (Ref)

Fixes #3609

Checklist

  • Unit tests updated
  • End user documentation updated

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 28, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: avi-08 / name: Avi Sharma (79987b3)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 28, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @avi-08!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 28, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 28, 2023
mloiseleur
mloiseleur reviewed Jul 28, 2023
View reviewed changes
Copy link
Contributor

@mloiseleur mloiseleur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please also update documentation about this ?

@johngmyers
Copy link
Contributor

Unfortunately, I'm not finding any documentation to update. There's no list outside of the code that shows the types of resources it can alias.

/ok-to-test
/lgtm
/assign @szuecs

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 28, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 28, 2023
@johngmyers
Copy link
Contributor

@avi-08 Please rebase to clear the failed Action

@avi-08 avi-08 force-pushed the add-aws-api-gw-zones branch from 44c7ff2 to 79987b3 Compare August 4, 2023 11:42
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2023
@avi-08
Copy link
Contributor Author

avi-08 commented Aug 4, 2023

/retest

@avi-08
Copy link
Contributor Author

avi-08 commented Aug 4, 2023

/test pull-external-dns-lint

@johngmyers
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2023
@avi-08
Copy link
Contributor Author

avi-08 commented Aug 17, 2023

@szuecs PTAL if the changes look good.

@szuecs
Copy link
Contributor

szuecs commented Aug 23, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avi-08, mloiseleur, szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2023
@k8s-ci-robot k8s-ci-robot merged commit 9deee07 into kubernetes-sigs:master Aug 23, 2023
@avi-08 avi-08 deleted the add-aws-api-gw-zones branch August 24, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mloiseleur mloiseleur mloiseleur approved these changes

@johngmyers johngmyers Awaiting requested review from johngmyers

@szuecs szuecs Awaiting requested review from szuecs

Assignees

@szuecs szuecs

@johngmyers johngmyers

@mloiseleur mloiseleur

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Errors with cname records targeting AWS API Gateways
5 participants
@avi-08 @k8s-ci-robot @johngmyers @szuecs @mloiseleur