Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: Don't suppress configuration for registries other than TXT #3736

Merged
merged 2 commits into from
Jun 29, 2023
Merged

helm: Don't suppress configuration for registries other than TXT #3736

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ad73aa
helm: Don't suppress configuration for registries other than TXT
johngmyers Jun 25, 2023
ef37683
Address review comment
johngmyers Jun 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions charts/external-dns/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ spec:
{{- end }}
- --policy={{ .Values.policy }}
- --registry={{ .Values.registry }}
{{- if eq .Values.registry "txt" }}
{{- if .Values.txtOwnerId }}
- --txt-owner-id={{ .Values.txtOwnerId }}
{{- end }}
Expand All @@ -88,7 +87,6 @@ spec:
{{- if and (eq .Values.txtPrefix "") (ne .Values.txtSuffix "") }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{{- if and (eq .Values.txtPrefix "") (ne .Values.txtSuffix "") }}
{{- if and (not .Values.txtPrefix "") .Values.txtSuffix }}

This change would be worth making for consistency while modifying this area.

- --txt-suffix={{ .Values.txtSuffix }}
{{- end }}
{{- end }}
{{- if .Values.namespaced }}
- --namespace={{ .Release.Namespace }}
{{- end }}
Expand Down
6 changes: 6 additions & 0 deletions charts/external-dns/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,9 +162,15 @@ sources:

policy: upsert-only

# Specifies the registry for storing ownership and labels.
# Valid values are "aws-sd", "noop", "dynamodb", and "txt".
registry: txt
# When using a registry other than "noop", specifies a name that
# uniquely identifies this instance of external-dns.
txtOwnerId: ""
# Specifies a prefix for the domain names of TXT records created by the "txt" registry. Optional.
johngmyers marked this conversation as resolved.
Show resolved Hide resolved
txtPrefix: ""
# Specifies a suffix for the domain names of TXT records created by the "txt" registry. Optional.
johngmyers marked this conversation as resolved.
Show resolved Hide resolved
txtSuffix: ""

domainFilters: []
Expand Down