fix clean apk cache directory

[fougner]

alpine uses /var/cache/apk, not apt

Description

Haven't opened an issue, the problem is obvious and fix is trivial. Correctly cleaning up APKINDEX saves ~1.8M from the built alpine image.

Alternative solution, which is less verbose, would be to just use
apk add --no-cache "libcrypto3>=3.0.8-r4" "libssl3>=3.0.8-r4"

Checklist

• Unit tests updated
• End user documentation updated

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: fougner (f132f1d)

[k8s-ci-robot]

Welcome @fougner!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[fougner]

/easycla

[piotrkpc]

looks good to me, but I have minor question: isn't the apk cache clean doing the same?

[johngmyers]

/lgtm

[johngmyers]

/ok-to-test

[fougner]

looks good to me, but I have minor question: isn't the apk cache clean doing the same?

Index is still left, so it probably just removes the package caches.

 $ docker run -it alpine:3.18 sh
/ # apk update
fetch https://dl-cdn.alpinelinux.org/alpine/v3.18/main/x86_64/APKINDEX.tar.gz
fetch https://dl-cdn.alpinelinux.org/alpine/v3.18/community/x86_64/APKINDEX.tar.gz
v3.18.2-316-g7d500b620dd [https://dl-cdn.alpinelinux.org/alpine/v3.18/main]
v3.18.2-315-ga3c91f8b49b [https://dl-cdn.alpinelinux.org/alpine/v3.18/community]
OK: 20065 distinct packages available
/ # apk cache clean
/ # ls /var/cache/apk/
APKINDEX.49104001.tar.gz  APKINDEX.884188d8.tar.gz

[Raffo]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fougner, mloiseleur, piotrkpc, Raffo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Raffo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment