Improve registry documentation #3652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
piotrkpc
reviewed
Jun 8, 2023
| The most important metadata is the owning external-dns deployment. | ||
| This is specified using the `--txt-owner-id` flag, specifying a value unique to the | ||
| deployment of external-dns and which doesn't change for the lifetime of the deployment. | ||
| Deployments in different clusters but sharing a DNS zone need to use different owner IDs. |
There was a problem hiding this comment.
I understand the need to use different owner IDs but is there any logic that would enforce this?
There was a problem hiding this comment.
There's no way to cause an error message. Any mechanism to detect an fail on duplicate owner IDs would be equivalent to generating unique owner IDs.
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johngmyers, szuecs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@johngmyers so good to have you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves the documentation of registry implementations and options.
Checklist
Unit tests updated