Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect arg in Oracle OCI tutorial #3558

Merged

Conversation

ericrrath
Copy link
Contributor

Description

The recently-added support for Oracle's OCI IAM instance principal authentication included an incorrect arg name in the change to the Oracle tutorial. This changes the tutorial to specify the correct arg name. Thanks to [email protected] for spotting the problem.

Fixes #3545

Checklist

  • Unit tests updated
  • End user documentation updated

The recently-added support for Oracle's OCI IAM instance principal
authentication included an incorrect arg name in the change to the Oracle
tutorial.  This changes the tutorial to specify the correct arg name.  Thanks to
[email protected] for spotting the problem.
@k8s-ci-robot k8s-ci-robot requested a review from njuettner April 20, 2023 17:34
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 20, 2023
@k8s-ci-robot k8s-ci-robot requested a review from seanmalloy April 20, 2023 17:34
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 20, 2023
@seanmalloy
Copy link
Member

/kind documentation
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Apr 20, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 20, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ericrrath, jrosinsk, seanmalloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2023
@k8s-ci-robot k8s-ci-robot merged commit 5dfdf1c into kubernetes-sigs:master Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unknown long flag '--oci-instance-principals'"
4 participants