Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(adguardhome): Add AdGuard Home provider #3520

Closed

Conversation

gabe565
Copy link
Contributor

@gabe565 gabe565 commented Mar 30, 2023

Description

This PR adds an AdGuard Home provider, which manages DNS rewrite entries for AdGuard Home.

The provider uses AdGuard Home's JSON API to create/delete records. AdGuard Home only supports A/AAAA/CNAME DNS rewrites, so ownership is not supported (similarly to the PiHole provider).

Fixes #3243

Checklist

  • Unit tests updated
  • End user documentation updated

Example DNS Rewrites

dns-rewrites

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 30, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: gabe565 / name: Gabe Cook (1212386)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gabe565
Once this PR has been reviewed and has the lgtm label, please assign raffo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 30, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @gabe565!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 30, 2023
@gabe565
Copy link
Contributor Author

gabe565 commented Mar 30, 2023

Oops, somehow I missed #3367 before now. I'll leave this open for now since my implementation:

  • Uses URL rewrites instead of custom filtering rules. URL rewrites support CNAME records and are meant for rewriting DNS responses, so I feel they make more sense for external-dns. Also, the DNS rewrite API does not rely on string parsing.
  • Supports skipping TLS validation
  • Supports disabled authentication
  • Adds flags for AdGuard Home config instead of solely using envs

Feel free to let me know if I should close this.

@gabe565 gabe565 force-pushed the add-provider-adguard-home branch from 2aa31db to 8f69606 Compare March 30, 2023 21:01
@gabe565 gabe565 mentioned this pull request Mar 30, 2023
2 tasks
@gabe565 gabe565 force-pushed the add-provider-adguard-home branch from 8f69606 to 8d0c812 Compare March 30, 2023 21:08
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 14, 2023
@gabe565 gabe565 force-pushed the add-provider-adguard-home branch from 8d0c812 to 1212386 Compare June 7, 2023 20:16
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 7, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 24, 2023
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mloiseleur
Copy link
Contributor

Hello,

#3063 has been merged. A plugin for adguard is already available here.
=> I'm closing this PR.
/close

@k8s-ci-robot
Copy link
Contributor

@mloiseleur: Closed this PR.

In response to this:

Hello,

#3063 has been merged. A plugin for adguard is already available here.
=> I'm closing this PR.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adguard Home Support (new Provider)
3 participants