-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for MX records in Azure, GCP and AWS #3519
Add support for MX records in Azure, GCP and AWS #3519
Conversation
|
25058df
to
205e8c0
Compare
/ok-to-test |
b587e33
to
b265cbf
Compare
Please add:
|
@szuecs thanks for looking into this! I've pushed all the changes that you requested. Please let me know if there's anything missing. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Sewci0, szuecs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@szuecs PR seems to be missing the |
I thought @odinuge would maybe add the lgtm |
/lgtm |
Description
Add support for
MX
record types in Azure, GCP and AWS. This still needs to be explicitly enabled by specifying a CLI flag--managed-record-types=MX
.Tested on all 3 cloud providers with a CRD source:
Checklist