Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MX records in Azure, GCP and AWS #3519

Merged
merged 8 commits into from
May 15, 2023

Conversation

Sewci0
Copy link
Contributor

@Sewci0 Sewci0 commented Mar 30, 2023

Description

Add support for MX record types in Azure, GCP and AWS. This still needs to be explicitly enabled by specifying a CLI flag --managed-record-types=MX.

Tested on all 3 cloud providers with a CRD source:

apiVersion: externaldns.k8s.io/v1alpha1
kind: DNSEndpoint
metadata:
  name: test-mxrecord
spec:
  endpoints:
  - dnsName: example.com
    recordTTL: 180
    recordType: MX
    targets:
    - 10 mail.example.com
    - 30 mail.foo.com

Checklist

  • Unit tests updated
  • End user documentation updated

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 30, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot requested a review from njuettner March 30, 2023 19:13
@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 30, 2023
@k8s-ci-robot k8s-ci-robot requested a review from seanmalloy March 30, 2023 19:13
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 30, 2023
@Sewci0 Sewci0 closed this Mar 30, 2023
@Sewci0 Sewci0 reopened this Mar 30, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 30, 2023
@Sewci0 Sewci0 force-pushed the feature/mx-support branch from 25058df to 205e8c0 Compare March 30, 2023 19:32
@odinuge
Copy link
Member

odinuge commented Mar 31, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 31, 2023
@Sewci0 Sewci0 force-pushed the feature/mx-support branch from b587e33 to b265cbf Compare March 31, 2023 12:14
provider/azure/common.go Outdated Show resolved Hide resolved
@szuecs
Copy link
Contributor

szuecs commented Apr 24, 2023

Please add:

  • a test for aws
  • end user documentation
  • document why nolint directive was used (it's fine but for our future self we should make sure we remember it

@Sewci0 Sewci0 force-pushed the feature/mx-support branch from ee9e87b to 2533415 Compare May 2, 2023 16:30
@Sewci0
Copy link
Contributor Author

Sewci0 commented May 2, 2023

@szuecs thanks for looking into this! I've pushed all the changes that you requested. Please let me know if there's anything missing.

@szuecs
Copy link
Contributor

szuecs commented May 3, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Sewci0, szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2023
@Sewci0
Copy link
Contributor Author

Sewci0 commented May 15, 2023

@szuecs PR seems to be missing the lgtm label. Should I ping someone to get that added? Thanks!

@szuecs
Copy link
Contributor

szuecs commented May 15, 2023

I thought @odinuge would maybe add the lgtm

@szuecs
Copy link
Contributor

szuecs commented May 15, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2023
@k8s-ci-robot k8s-ci-robot merged commit 3346b4e into kubernetes-sigs:master May 15, 2023
@Sewci0 Sewci0 deleted the feature/mx-support branch May 16, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants