docker buildx and tester #3472
Merged
docker buildx and tester #3472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raffaele Di Fazio <[email protected]>
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Raffo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Signed-off-by: Raffaele Di Fazio <[email protected]>
Signed-off-by: Raffaele Di Fazio <[email protected]>
Signed-off-by: Raffaele Di Fazio <[email protected]>
Signed-off-by: Raffaele Di Fazio <[email protected]>
Signed-off-by: Raffaele Di Fazio <[email protected]>
Signed-off-by: Raffaele Di Fazio <[email protected]>
Signed-off-by: Raffaele Di Fazio <[email protected]>
Signed-off-by: Raffaele Di Fazio <[email protected]>
Signed-off-by: Raffaele Di Fazio <[email protected]>
k8s-ci-robot
added
size/L
Signed-off-by: Raffaele Di Fazio <[email protected]>
Signed-off-by: Raffaele Di Fazio <[email protected]>
Signed-off-by: Raffaele Di Fazio <[email protected]>
Signed-off-by: Raffaele Di Fazio <[email protected]>
Signed-off-by: Raffaele Di Fazio <[email protected]>
Raffo
added
the
tide/merge-method-squash
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Signed-off-by: Raffaele Di Fazio <[email protected]>
szuecs
reviewed
Mar 17, 2023
szuecs
reviewed
Mar 17, 2023
Signed-off-by: Raffaele Di Fazio <[email protected]>
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This introduces docker buildx so that we can more properly build multiarch images. Until today, we relied on a hack and that caused the builds to be slow and to stop building once that we had the requirement to actually have at least a
RUNinstruction in the Dockerfile.It also introduces a new github action that actually builds the images in CI without needing to merge so that we can test if images are building all time time.
Possible risks: we have no way to try this against kubernetes' CI other than merging, so we have to try and merge this and in the worst case iterate on it incrementally.