chore: Fixed GH action workflow approval #3354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
size/M
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
Signed-off-by: Steve Hipwell <[email protected]>
stevehipwell
force-pushed
the
fix-workflow-approval
branch
from
abe0e3f to
bda730c
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/assign @Raffo |
|
I think it would also be correct to change the repo settings to always require approval from external contributors, this would align better with how Prow works.
|
|
@stevehipwell I changed that setting, approving this PR too. |
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Raffo, stevehipwell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the GH Workflow approval action which I previously added. I have debugged why this was working correctly on my CLI but not in the action and I have run it in a test repo to prove that it functioning correctly without errors.
Checklist