-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added traefik-proxy rules to helm chart #3325
Added traefik-proxy rules to helm chart #3325
Conversation
/ok-to-test |
/ok-to-test |
/hold |
/unhold (I was testing the approve workflows action) |
/hold Testing the approve GH Actions workflow again. |
/unhold |
/hold Testing the approve GH Actions workflow again. |
/unhold It worked!! 🥳 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ThomasK33 thanks for your patience. Could you add a chart CHANGELOG entry under a new ## [UNRELEASED]
heading at the top and following the conventions from the last entry?
@ThomasK33 ignore the bit about the next release as I can see that this is waiting on #3055 but it'd still be good to have a CHANGELOG entry for the chart in the PR. |
Sure, I'll update it today, but there is no point in having this in the next release, as #3055 still isn't merged. |
fb40403
to
0c720c5
Compare
Hey @stevehipwell 👋 As #3055 was merged last week, I've updated this PR to include the additional, new apiGroup for Traefik Let me know if anything else needs to be added. 😄 |
Signed-off-by: Thomas Kosiewski <[email protected]>
Signed-off-by: Thomas Kosiewski <[email protected]>
5516510
to
c7a073e
Compare
@njuettner could you take a look for a LGTM? /approve |
@mloiseleur: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mloiseleur, stevehipwell, ThomasK33 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
As a follow-up to #3055, as suggested by @stevehipwell.
Only merge this once #3055 is merged onto the master.