chore(chart): Reverted chart changes to args

Signed-off-by: Steve Hipwell <[email protected]>
kubernetes-sigs · Apr 26, 2023 · 371ba2c · 371ba2c
1 parent 21da27f
commit 371ba2c
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 7 deletions.
diff --git a/charts/external-dns/README.md b/charts/external-dns/README.md
@@ -83,7 +83,6 @@ The following table lists the configurable parameters of the _ExternalDNS_ chart
 | `secretConfiguration.mountPath`    | Mount path of secret configuration secret (this can be templated).                                                                                                                                                                                                                                                    | `""`                                        |
 | `secretConfiguration.data`         | Secret configuration secret data. Could be used to store DNS provider credentials.                                                                                                                                                                                                                                    | `{}`                                        |
 | `secretConfiguration.subPath`      | Sub-path of secret configuration secret (this can be templated).                                                                                                                                                                                                                                                      | `""`                                        |
-| `resolveServiceLoadBalancerHostname`      | Resolve the hostname of LoadBalancer-type Service object to IP addresses in order to create DNS A/AAAA records instead of CNAMEs | `false`                                        |
 
 ## Namespaced scoped installation
 

diff --git a/charts/external-dns/templates/deployment.yaml b/charts/external-dns/templates/deployment.yaml
@@ -96,9 +96,6 @@ spec:
             - --domain-filter={{ . }}
             {{- end }}
             - --provider={{ tpl .Values.provider $ }}
-            {{- if .Values.resolveServiceLoadBalancerHostname }}
-            - --resolve-service-load-balancer-hostname
-            {{- end }}
           {{- range .Values.extraArgs }}
             - {{ tpl . $ }}
           {{- end }}

diff --git a/charts/external-dns/values.yaml b/charts/external-dns/values.yaml
@@ -15,8 +15,6 @@ fullnameOverride: ""
 
 commonLabels: {}
 
-resolveServiceLoadBalancerHostname: false
-
 serviceAccount:
   # Specifies whether a service account should be created
   create: true
@@ -176,7 +174,8 @@ secretConfiguration:
   enabled: false
   mountPath: ""
   subPath: ""
-  data: {}
+  data:
+    {}
     # credentials: |
     #   [default]
     #   aws_access_key_id = $SECRET_ACCESS_KEY