New provider-specific properties support when updating DNS records

shouldUpdateProviderSpecific seems to be iterating over just the current properties that were previously set, not taking into consideration for planning changes when additional ProviderSpecific properties were just set.

The previous code version only iterates over current ProviderSpecific properties. This new version iterates over desired properties, including those that were just set.

plan/plan.go

@@ -212,8 +212,8 @@ func (p *Plan) shouldUpdateProviderSpecific(desired, current *endpoint.Endpoint)
 	currentProperties := map[string]endpoint.ProviderSpecificProperty{}
 
 	if current.ProviderSpecific != nil {
-		for _, d := range current.ProviderSpecific {
-			currentProperties[d.Name] = d
+		for _, c := range current.ProviderSpecific {
+			currentProperties[c.Name] = c
 		}
 	}
 
@@ -229,7 +229,7 @@ func (p *Plan) shouldUpdateProviderSpecific(desired, current *endpoint.Endpoint)
 				}
 			} else {
 				if p.PropertyComparator != nil {
-					if !p.PropertyComparator(c.Name, "", d.Value) {
+					if !p.PropertyComparator(d.Name, "", d.Value) {
 						return true
 					}
 				} else if d.Value != "" {