Fixing issues with flags parsing #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
sig/testing
vladimirvivien
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
/test pull-e2e-framework-test |
vladimirvivien
force-pushed
the
flags-fix
branch
from
823e71d to
4b67895
Compare
k8s-ci-robot
added
size/L
vladimirvivien
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
vladimirvivien
force-pushed
the
flags-fix
branch
3 times, most recently
from
69ad4d9 to
07b5f11
Compare
This patch rework how flags are supported and parsed in the test framework. All framework flags are merged with the go-generated test binary flags. This fix also rework how/when envconf.Config are used to create klien.Client to avoid errors when flags do not provide needed config values. Signed-off-by: Vladimir Vivien <[email protected]>
vladimirvivien
force-pushed
the
flags-fix
branch
from
07b5f11 to
84baa29
Compare
|
@ShwethaKumbla - this is finally building. PTAL. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
ShwethaKumbla
approved these changes
Oct 8, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ShwethaKumbla, vladimirvivien The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fricounet
added a commit
to Fricounet/e2e-framework
that referenced
this pull request
Apr 17, 2024
Currently, the config's client is managed as follow: - it can be created with `NewClient` and `Client`. However, once it is created, it is cached and will always be returned. - it can be set directly with `WithClient`. The current approach has a few drawbacks when running tests in parallel: - the client is shared between tests, leading to race conditions when it is initialized at the same time in multiple tests. - because of the caching, if one gets the client, modifies the kubeconfig or any other client related parameter in the config, and then gets the client again, they would get the original client and not a new one with the new kubeconfig. - `Client` is not a simple getter function like all the other similar methods of the config, which makes it confusing to users. This commit attempts to fix this by initializing the client earlier but currently does not work for in-cluster clients. It conflicts with changes made in kubernetes-sigs#57.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56