Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add qps/burst flag for k8s client, and provide method to hide these flags #121

Merged
merged 1 commit into from
Dec 9, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion pkg/cmd/builder.go
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,10 @@ type AdapterBase struct {
// DiscoveryInterval specifies the interval at which to recheck discovery
// information for the discovery RESTMapper. It's set from a flag.
DiscoveryInterval time.Duration
// ClientQPS specifies the maximum QPS for the client-side throttle. It's set from a flag.
ClientQPS float32
// ClientBurst specifies the maximum QPS burst for client-side throttle. It's set from a flag.
ClientBurst int

// FlagSet is the flagset to add flags to.
// It defaults to the normal CommandLine flags
Expand Down Expand Up @@ -110,7 +114,9 @@ func (b *AdapterBase) InstallFlags() {
"kubeconfig file pointing at the 'core' kubernetes server with enough rights to list "+
"any described objects")
b.FlagSet.DurationVar(&b.DiscoveryInterval, "discovery-interval", b.DiscoveryInterval,
"interval at which to refresh API discovery information")
"Interval at which to refresh API discovery information")
b.FlagSet.Float32Var(&b.ClientQPS, "client-qps", rest.DefaultQPS, "Maximum QPS for client-side throttle")
b.FlagSet.IntVar(&b.ClientBurst, "client-burst", rest.DefaultBurst, "Maximum QPS burst for client-side throttle")
})
}

Expand Down Expand Up @@ -153,6 +159,13 @@ func (b *AdapterBase) ClientConfig() (*rest.Config, error) {
}
b.clientConfig = clientConfig
}

if b.ClientQPS > 0 {
b.clientConfig.QPS = b.ClientQPS
}
if b.ClientBurst > 0 {
b.clientConfig.Burst = b.ClientBurst
}
return b.clientConfig, nil
}

Expand Down