-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crictl-exec: fix argument parsing #306
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Given 970fcf5, I will break it up into multiple commits to also add short opt handling for the remaining commands. The |
A command's arguments have been interpreted as flags leading to various kinds of errors. Fix it by vendoring the latest urfave/cli and setting the corresponding cli.Command flag to avoid reordering of arguments. Signed-off-by: Valentin Rothberg <[email protected]> Fixes: #305
Allow handling of short options (e.g., `exec -it` vs `exec -i -t). Signed-off-by: Valentin Rothberg <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@vrothberg Thanks for the fix /lgtm |
Commits:
Signed-off-by: Valentin Rothberg [email protected]
Fixes: #305