Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Markers can now indicate their priority when applying #706

Merged
merged 11 commits into from
Feb 5, 2024
Merged

✨ Markers can now indicate their priority when applying #706

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8df4154
Markers can now indicate their priority when applying
dprotaso Jul 15, 2022
2a3e4d9
add unit test to ensure marker invocation
dprotaso Jul 15, 2022
4710a92
add example in godoc
dprotaso Dec 5, 2022
43c8282
drop unused struct param
dprotaso Dec 5, 2022
bc48feb
update godoc
dprotaso Dec 6, 2022
11c6121
run goimports
dprotaso Dec 6, 2022
0db0ef2
change marker constants
dprotaso May 29, 2023
08da28b
add godoc comment
dprotaso May 29, 2023
852fc90
address feedback
dprotaso Jan 25, 2024
f9cffe3
add comment that ordering is for validation markers for now
dprotaso Jan 31, 2024
239ff67
fix godoc comment
dprotaso Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix godoc comment
  • Loading branch information
@dprotaso
dprotaso committed Jan 31, 2024
commit 239ff67a447356eb4be275ec7feb2ecb3e695271
2 changes: 1 addition & 1 deletion pkg/crd/markers/doc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ limitations under the License.
// # CRD Markers
//
// Markers that modify anything in the CRD itself *except* for the schema
// implement ApplyToCRD (crd.CRDMarker). They are expected to detect whether
// implement ApplyToCRD (crd.SpecMarker). They are expected to detect whether
// they should apply themselves to a specific version in the CRD (as passed to
// them), or to the root-level CRD for legacy cases. They are applied *after*
// the rest of the CRD is computed.
Expand Down