-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ upgrade to k8s 0.27.1 #2189
✨ upgrade to k8s 0.27.1 #2189
Conversation
Welcome @mythi! |
Hi @mythi. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
99ee96b
to
dab6f18
Compare
I have an alternative PR that makes controller-runtime support 1.27 and 1.26 concurrently so projects do not need to serialize updates: #2223 I am also fine with this, just presenting an option. I would like to see some support for 1.27 merged ideally, though. |
I'm totally fine with the proposed alternative. My goal (this PR) was also to just get to 1.27... |
Rebased since #2223 is now merged. |
@alvaroaleman @vincepri could I get |
/ok-to-test |
lgtm from my side pending 0.27.2 and resolution of #2189 (comment) (let's wait for feedback there) |
k8s.io/apimachinery deprecated legacy Poll methods and this triggers golangi-lint staticheck errors. Rework all the poll logic to move to the preferred methods. Additionally, NamespacedName type no implements MarshalLog() which replaces the functionality in kube_helpers.go. See k/k #117238. Signed-off-by: Mikko Ylinen <[email protected]>
@mythi Thank you very much for all your work on this!! /lgtm |
/assign @vincepri @alvaroaleman |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, mythi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
Please note that we are still waiting for v0.27.2 with the v0.15 release. Follow-up issue: #2297 |
no problem. Even if this PR turned out to be WAY bigger task than I originally planned, I don't mind since I believe it gives a good learning for the future as well: it's probably good to start pulling/testing k8s release candidates to ensure all is good ahead of the release. |
This PR moves k8s dependencies to 0.27.1 and reworks things to make the tests/linter happy.
k8s.io/apimachinery deprecated legacy Poll methods and this
triggers golangi-lint staticheck errors.
Rework all the poll logic to move to the preferred methods.
Details: kubernetes/apimachinery@831cf05
Additionally, NamespacedName type now implements MarshalLog() which
replaces the functionality in kube_helpers.go. See k/k #117238..