-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to still using Component Config besides it be deprecated only #2370
Comments
Sorry, I don't understand the bug. Could you provide a sample snippet of what you are trying to do? |
ComponentConfig was removed from the upstream controller-runtime as described here kubernetes-sigs/kubebuilder#3469. Although only deprecated, there are now issues with it, as described here kubernetes-sigs/controller-runtime#2370. Because the ComponentConfig was not used until now, it can be removed from the project.
ComponentConfig was removed from the upstream controller-runtime as described here kubernetes-sigs/kubebuilder#3469. Although only deprecated, there are now issues with it, as described here kubernetes-sigs/controller-runtime#2370. Because the ComponentConfig was not used until now, it can be removed from the project.
/kind support Is this issue fixed with the above pull request to guacamole-operator? @camilamacedo86 |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
Hi @alvaroaleman, The ComponentConfig was deprecated; therefore, it should still work fine until being removed and no longer supported.
Anyway, I think that can be closed. It was not well adopted because we did not face complaints from Kubebuilder users, and we have already been communicating that soon we will do a MAJOR release where this option will be removed from there. Therefore, I am closing this one |
Run into this issue when bump controller-runtime to 0.16.x and apimachinery to compatible version. |
We are facing a hard time to bump Controller-Runtime 0.15.0 due the breaking changes.
We noticed that the ComponentConfig was deprecated. #895
However, it seems that it also has a bug. This means when ctrl.File is called in cmd/main.go it calls in here which registers the ComponentConfig with the scheme. Though the field has been deprecated, the ComponentConfig type should still be registered with controller-runtime.sigs.k8s.io/v1alpha1 scheme, which seems missing.
The text was updated successfully, but these errors were encountered: