add test, fix wording in errors.go

Signed-off-by: Vince Prignano <[email protected]>

go.mod

@@ -3,7 +3,6 @@ module sigs.k8s.io/controller-runtime
 go 1.20
 
 require (
-	github.com/davecgh/go-spew v1.1.1
 	github.com/evanphx/json-patch v5.6.0+incompatible
 	github.com/evanphx/json-patch/v5 v5.6.0
 	github.com/fsnotify/fsnotify v1.6.0
@@ -31,6 +30,7 @@ require (
 require (
 	github.com/beorn7/perks v1.0.1 // indirect
 	github.com/cespare/xxhash/v2 v2.2.0 // indirect
+	github.com/davecgh/go-spew v1.1.1 // indirect
 	github.com/emicklei/go-restful/v3 v3.9.0 // indirect
 	github.com/go-openapi/jsonpointer v0.19.6 // indirect
 	github.com/go-openapi/jsonreference v0.20.2 // indirect

pkg/cache/errors/errors.go

@@ -6,15 +6,15 @@ import (
 	"k8s.io/apimachinery/pkg/runtime/schema"
 )
 
-// ErrResourceNotCached indicates that the resource type the client asked the cache for is not cached, and
-// the cache is configured to fail on a cache miss.
+// ErrResourceNotCached indicates that the resource type
+// the client asked the cache for is not cached.
 type ErrResourceNotCached struct {
 	GVK schema.GroupVersionKind
 }
 
 // Error returns the error
 func (r ErrResourceNotCached) Error() string {
-	return fmt.Sprintf("%s is not cached and the cache is configured to fail on miss", r.GVK.String())
+	return fmt.Sprintf("%s is not cached", r.GVK.String())
 }
 
 var _ error = (*ErrResourceNotCached)(nil)

pkg/manager/manager_test.go

@@ -581,6 +581,16 @@ var _ = Describe("manger.Manager", func() {
 			Expect(listener.Close()).ToNot(HaveOccurred())
 		})
 
+		It("should should be able to create a manager with a cache to fail on unknown resources", func() {
+			m, err := New(cfg, Options{
+				Cache: cache.Options{
+					FailOnUnknownResource: true,
+				},
+			})
+			Expect(m).ToNot(BeNil())
+			Expect(err).ToNot(HaveOccurred())
+		})
+
 		It("should return an error if the metrics bind address is already in use", func() {
 			ln, err := metrics.NewListener(":0")
 			Expect(err).ShouldNot(HaveOccurred())