Skip to content

Commit

Permalink
Merge pull request #11911 from sivchari/enable-nobools
Browse files Browse the repository at this point in the history
🌱 Enable nobools linter
  • Loading branch information
k8s-ci-robot authored Mar 3, 2025
2 parents 26d562e + 0d317ad commit e95ff05
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion .golangci-kal.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ linters-settings:
- "statussubresource" # All root objects that have a `status` field should have a status subresource.
- "nofloats" # Ensure floats are not used.
- "maxlength" # Ensure all strings and arrays have maximum lengths/maximum items.
- "nobools" # Bools do not evolve over time, should use enums instead.

# Per discussion in July 2024, we are keeping phase fields for now.
# See https://github.com/kubernetes-sigs/cluster-api/pull/10897#discussion_r1685929508
Expand All @@ -30,7 +31,6 @@ linters-settings:
# Linters below this line are disabled, pending conversation on how and when to enable them.
# - "commentstart" # Ensure comments start with the serialized version of the field name.
# - "jsontags" # Ensure every field has a json tag.
# - "nobools" # Bools do not evolve over time, should use enums instead.
# - "optionalorrequired" # Every field should be marked as `+optional` or `+required`.
# - "requiredfields" # Required fields should not be pointers, and should not have `omitempty`.
disable:
Expand Down Expand Up @@ -78,3 +78,7 @@ issues:
text: "maxlength"
linters:
- kal
- path: "api/v1alpha1/*|api/v1beta1/*"
text: "nobools"
linters:
- kal

0 comments on commit e95ff05

Please sign in to comment.