Convert virtualmachines service to SDKv2

[mboersma]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Converts the virtualmachines service to azure-sdk-for-go version 2 and the asyncpoller framework.

Which issue(s) this PR fixes:

Fixes #3918

Special notes for your reviewer:

• cherry-pick candidate

TODOs:

• squashed commits
• includes documentation
• adds unit tests

Release note:

NONE

[mboersma]

/retitle [WIP] Convert virtualmachines service to SDKv2

This needs to be rebased when scalesetvms has merged.

Edit: rebased.

[codecov]

Codecov Report

Patch coverage: 58.28% and project coverage change: +0.04% 🎉

Comparison is base (4f076e6) 56.68% compared to head (f49b5ac) 56.72%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3996      +/-   ##
==========================================
+ Coverage   56.68%   56.72%   +0.04%     
==========================================
  Files         188      188              
  Lines       19328    19189     -139     
==========================================
- Hits        10956    10885      -71     
+ Misses       7739     7671      -68     
  Partials      633      633              

Files Changed	Coverage Δ
azure/services/scalesetvms/scalesetvms.go	60.20% <0.00%> (-2.57%)	⬇️
azure/services/virtualmachines/client.go	0.00% <0.00%> (ø)
azure/services/roleassignments/roleassignments.go	60.95% <14.28%> (-2.42%)	⬇️
azure/services/virtualmachines/virtualmachines.go	70.83% <35.71%> (-1.51%)	⬇️
azure/services/virtualmachines/spec.go	86.48% <92.10%> (-1.87%)	⬇️
azure/converters/diagnostics.go	100.00% <100.00%> (ø)
azure/converters/extendedlocation.go	100.00% <100.00%> (ø)
azure/converters/identity.go	100.00% <100.00%> (ø)
azure/converters/image.go	100.00% <100.00%> (+18.65%)	⬆️
azure/converters/spotinstances.go	84.21% <100.00%> (ø)
... and 2 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mboersma]

/retitle Convert virtualmachines service to SDKv2

[mboersma]

/test pull-cluster-api-provider-azure-e2e-optional

[nojnhuh]

Seeing a lot of these in the controller logs:

E0913 20:16:00.914141       1 controller.go:324]  "msg"="Reconciler error" "error"="failed to reconcile AzureMachine: failed to reconcile AzureMachine service virtualmachine: failed to create or update resource capz-e2e-dfomdc-ha/capz-e2e-dfomdc-ha-md-0-5nlp8 (service: virtualmachine): <nil> is not an armcompute.VirtualMachine" "AzureMachine"={"name":"capz-e2e-dfomdc-ha-md-0-5nlp8","namespace":"capz-e2e-dfomdc"} "controller"="azuremachine" "controllerGroup"="infrastructure.cluster.x-k8s.io" "controllerKind"="AzureMachine" "name"="capz-e2e-dfomdc-ha-md-0-5nlp8" "namespace"="capz-e2e-dfomdc" "reconcileID"="2898a69e-3120-43af-9659-72a7a6f3056e"

[mboersma]

Thanks @nojnhuh, those are great comments and I incorporated them all. 🤞🏻

[nojnhuh]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 43e9da787b31edc3233a5f1403235996e5dd4e88

[mboersma]

/test pull-cluster-api-provider-azure-e2e-optional

[mboersma]

/assign @CecileRobertMichon @jackfrancis

[CecileRobertMichon]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [CecileRobertMichon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment