-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update error funcs for SDKv2 #3812
Conversation
Skipping CI for Draft Pull Request. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3812 +/- ##
==========================================
+ Coverage 54.77% 54.82% +0.05%
==========================================
Files 187 187
Lines 19098 19099 +1
==========================================
+ Hits 10460 10471 +11
+ Misses 8070 8060 -10
Partials 568 568
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 0ce68ee9dae056755ffc74acda58aa93fb792b8b
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nojnhuh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Updates the
ResourceConflict()
andResourceNotFound()
error helper funcs to also recognize Azure SDK for Go v2 error types.Also removes the unused
ResourceGroupNotFound()
func, does some refactoring to simplify, and adds unit test coverage.Which issue(s) this PR fixes:
Refs #2974
Special notes for your reviewer:
I extracted this from my larger PR in-progress because it stands on its own. I'll keep trying to do that to keep the pieces reviewable.
TODOs:
Release note: