[WIP] Convert natgateways and vnetpeerings services to SDK v2

[mboersma]

What type of PR is this?

/kind feature

What this PR does / why we need it:

Converts the natgateways and vnetpeerings services to use azure-sdk-for-go v2. Also adds the asyncpoller framework to support this, which is a variant of async that works with the new SDK.

Which issue(s) this PR fixes:

Refs #3409

Special notes for your reviewer:

TODOs:

• squashed commits
• includes documentation
• adds unit tests

Release note:

NONE

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from mboersma. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mboersma]

/retitle [WIP] Convert natgateways and vnetpeerings services to SDK v2

[codecov-commenter]

Codecov Report

Patch coverage: 0.69% and project coverage change: -0.44 ⚠️

Comparison is base (ba5ea79) 51.63% compared to head (4abc8a1) 51.19%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3410      +/-   ##
==========================================
- Coverage   51.63%   51.19%   -0.44%     
==========================================
  Files         182      183       +1     
  Lines       18066    18221     +155     
==========================================
  Hits         9329     9329              
- Misses       8210     8365     +155     
  Partials      527      527              

Impacted Files	Coverage Δ
azure/converters/futures.go	47.50% <0.00%> (-38.87%)	⬇️
azure/errors.go	0.00% <0.00%> (ø)
azure/services/asyncpoller/asyncpoller.go	0.00% <0.00%> (ø)
azure/services/natgateways/client.go	0.00% <0.00%> (ø)
azure/services/natgateways/spec.go	4.44% <0.00%> (+0.36%)	⬆️
azure/services/vnetpeerings/client.go	0.00% <0.00%> (ø)
azure/services/vnetpeerings/spec.go	0.00% <0.00%> (ø)
azure/services/vnetpeerings/vnetpeerings.go	77.55% <0.00%> (-1.62%)	⬇️
azure/services/natgateways/natgateways.go	79.16% <40.00%> (-1.12%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[mboersma]

/close

These services seem to be implemented in ASO. My bad for not digging deeper! (No worries, I like to code.)

I'll keep this around locally as a POC, but I'm closing it to simplify maintainer life. When we figure out the actual services required to be implemented in SDK v2 (if any) I'll open a new PR.

[k8s-ci-robot]

@mboersma: Closed this PR.

In response to this:

/close

These services seem to be implemented in ASO. My bad for not digging deeper! (No worries, I like to code.)

I'll keep this around locally as a POC, but I'm closing it to simplify maintainer life. When we figure out the actual services required to be implemented in SDK v2 (if any) I'll open a new PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.