Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for configurable scope in system assigned identities #2965

Merged
merged 1 commit into from
Feb 15, 2023
Merged

Allow for configurable scope in system assigned identities #2965

merged 1 commit into from
Feb 15, 2023

Conversation

willie-yao
Copy link
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:
Currently, SystemAssigned identities automatically assign the scope of the identity to the entire subscription, as well as the contributor role for the role assignment. This PR allows the scope and role to be configurable via the AzureMachineTemplate spec.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2923

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Allow configurable scope and role assignment for SystemAssigned identities

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 21, 2022
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 21, 2022
@willie-yao willie-yao closed this Dec 21, 2022
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 21, 2022
@willie-yao
Copy link
Contributor Author

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Dec 21, 2022
@k8s-ci-robot
Copy link
Contributor

@willie-yao: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 21, 2022
@willie-yao willie-yao changed the title Allow for configurable scope in system assigned identities WIP: Allow for configurable scope in system assigned identities Dec 21, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 21, 2022
@willie-yao willie-yao force-pushed the identity-scope branch 3 times, most recently from 88fb8ad to f938b83 Compare December 22, 2022 23:40
@willie-yao
Copy link
Contributor Author

/retest

@willie-yao
Copy link
Contributor Author

/retest

@CecileRobertMichon CecileRobertMichon mentioned this pull request Jan 5, 2023
Merged
3 tasks
@jackfrancis jackfrancis added this to the v1.7 milestone Jan 5, 2023
mboersma
mboersma reviewed Feb 13, 2023
View reviewed changes
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just had some minor questions and comments.

api/v1beta1/azuremachine_default.go Show resolved Hide resolved
api/v1beta1/azuremachine_default.go Outdated Show resolved Hide resolved
api/v1beta1/azuremachine_types.go Outdated Show resolved Hide resolved
api/v1beta1/azuremachine_types.go Outdated Show resolved Hide resolved
api/v1beta1/azuremachine_validation.go Outdated Show resolved Hide resolved
exp/api/v1beta1/azuremachinepool_default.go Show resolved Hide resolved
sonasingh46
sonasingh46 approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@sonasingh46 sonasingh46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2023
@willie-yao willie-yao force-pushed the identity-scope branch 2 times, most recently from d89f05f to fcd0bce Compare February 13, 2023 21:53
CecileRobertMichon
CecileRobertMichon reviewed Feb 14, 2023
View reviewed changes
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 14, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6045fd59c4ea48d22e62900546fc74dc3052954e

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 14, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 14, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 14, 2023
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 14, 2023 •
edited
Loading

@willie-yao: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-apidiff 23617a1 link false /test pull-cluster-api-provider-azure-apidiff

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@CecileRobertMichon
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 15, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 334570511294977851fb22615332090b0b2bb096

@k8s-ci-robot k8s-ci-robot merged commit 0f9258e into kubernetes-sigs:main Feb 15, 2023
@CecileRobertMichon CecileRobertMichon mentioned this pull request Mar 16, 2023
Closed
@willie-yao willie-yao mentioned this pull request Mar 24, 2023
Merged
3 tasks
@willie-yao willie-yao deleted the identity-scope branch February 4, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@primeroz primeroz primeroz left review comments

@devigned devigned Awaiting requested review from devigned

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

@mboersma mboersma Awaiting requested review from mboersma

@sonasingh46 sonasingh46 Awaiting requested review from sonasingh46

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

Assignees

@mboersma mboersma

@CecileRobertMichon CecileRobertMichon

@sonasingh46 sonasingh46

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.

Allow configuring role assignment scope for system assigned VM identity
7 participants
@willie-yao @k8s-ci-robot @CecileRobertMichon @mboersma @primeroz @sonasingh46 @jackfrancis