-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade the azure-sdk-for-go to v67.0.0 #2762
Conversation
@luthermonson: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@luthermonson: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
oh boy... looks like i have a lot of deprecations to deal with. let me take a swipe at this and see what i come up with |
FYI @luthermonson there is also #2670 that is relevant |
thanks @CecileRobertMichon ill have time to look at this later in the week but i have my list and ill see what comes of this. |
@luthermonson sounds good, reach out if you need help! The migration issue I pasted above is a larger effort so if you're able to keep this PR to just the version bump for now that will probably make your life easier, just wanted you to be aware of it in case you run into issues because of it. |
sure good, idea... ill drop the fixes then |
just to be clear when I say just the version bump I mean with changes required to get tests passing |
@luthermonson Will you merge the PR? Thanks! I believe migration (#2670) takes some time. |
since this is still not merged, might as well do another bump IMO to the release from a couple weeks ago: |
@luthermonson are you able to get this ready to merge or should someone else take over? /milestone v1.7 |
@luthermonson: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/close done in #2906 |
@CecileRobertMichon: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
Utility PR to version bump the
github.com/Azure/azure-sdk-for-go
package to v67.0.0/kind cleanup
What this PR does / why we need it:
There are some features coming that my team is working on that requires the bump. Doing this as a one off to see if the tests all work before we start working on what we actually need.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
Release note: