Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the azure-sdk-for-go to v67.0.0 #2762

Closed

Conversation

luthermonson
Copy link
Contributor

@luthermonson luthermonson commented Oct 31, 2022

What type of PR is this?
Utility PR to version bump the github.com/Azure/azure-sdk-for-go package to v67.0.0
/kind cleanup

What this PR does / why we need it:
There are some features coming that my team is working on that requires the bump. Doing this as a one off to see if the tests all work before we start working on what we actually need.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:


@k8s-ci-robot
Copy link
Contributor

@luthermonson: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 31, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jackfrancis for approval by writing /assign @jackfrancis in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

@luthermonson: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-test ce76c7a link true /test pull-cluster-api-provider-azure-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@luthermonson
Copy link
Contributor Author

luthermonson commented Oct 31, 2022

oh boy... looks like i have a lot of deprecations to deal with. let me take a swipe at this and see what i come up with

@CecileRobertMichon
Copy link
Contributor

FYI @luthermonson there is also #2670 that is relevant

@luthermonson
Copy link
Contributor Author

thanks @CecileRobertMichon ill have time to look at this later in the week but i have my list and ill see what comes of this.

@CecileRobertMichon
Copy link
Contributor

@luthermonson sounds good, reach out if you need help! The migration issue I pasted above is a larger effort so if you're able to keep this PR to just the version bump for now that will probably make your life easier, just wanted you to be aware of it in case you run into issues because of it.

@luthermonson
Copy link
Contributor Author

sure good, idea... ill drop the fixes then

@CecileRobertMichon
Copy link
Contributor

ill drop the fixes then

just to be clear when I say just the version bump I mean with changes required to get tests passing

@jingai-db
Copy link
Contributor

@luthermonson Will you merge the PR? Thanks!

I believe migration (#2670) takes some time.

@dtzar
Copy link
Contributor

dtzar commented Nov 30, 2022

since this is still not merged, might as well do another bump IMO to the release from a couple weeks ago:
https://pkg.go.dev/github.com/Azure/[email protected]+incompatible

@CecileRobertMichon
Copy link
Contributor

@luthermonson are you able to get this ready to merge or should someone else take over?

/milestone v1.7

@k8s-ci-robot k8s-ci-robot added this to the v1.7 milestone Dec 1, 2022
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 7, 2022
@k8s-ci-robot
Copy link
Contributor

@luthermonson: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@CecileRobertMichon
Copy link
Contributor

/close

done in #2906

@k8s-ci-robot
Copy link
Contributor

@CecileRobertMichon: Closed this PR.

In response to this:

/close

done in #2906

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants