Fix GlobalPools determination of in use IPs #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The namespace of a Global pool is empty string. This commit changes the namespace parameter of the lookup for in use IPs to use the pool namespace instead of the claim namespace. In the case of InClusterIPPools the pool namespace matches the claim namespace. This namespace paramter is supplied to the in use IP lookup, and remains effectively the same. In the case of GlobalInClusterIPPools, using the pool namespace will result in an empty namespace string. This empty namespace string will be used to find in use IPs. The empty string causes the lookup to find addresses in all namespaces, which is needed in the case of a global pool. This commit addresses: kubernetes-sigs#98 Signed-off-by: Tyler Schultz <[email protected]> Co-authored-by: Edwin Xie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The namespace of a Global pool is empty string. This commit changes the namespace parameter of the lookup for in use IPs to use the pool namespace instead of the claim namespace.
In the case of InClusterIPPools the pool namespace matches the claim namespace. This namespace paramter is supplied to the in use IP lookup, and remains effectively the same.
In the case of GlobalInClusterIPPools, using the pool namespace will result in an empty namespace string. This empty namespace string will be used to find in use IPs. The empty string causes the lookup to find addresses in all namespaces, which is needed in the case of a global pool.
This commit addresses: #98
Fixes #98