Addresses can be specified as hyphenated ranges and CIDRs #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example: ```yaml Co-authored-by: Tyler Schultz <[email protected]> --- apiVersion: ipam.cluster.x-k8s.io/v1alpha1 kind: InClusterIPPool metadata: name: inclusterippool-sample spec: addresses: - 10.0.0.10-10.0.0.15 - 10.0.0.24/30 - 10.0.0.32 prefix: 24 gateway: 10.0.0.1 ``` Addresses that are ranges are validated to ensure they are contained by the prefix. Co-authored-by: Tyler Schultz <[email protected]> Co-authored-by: Aidan Obley <[email protected]>
Co-authored-by: Christian Ang <[email protected]>
Co-authored-by: Tyler Schultz <[email protected]>
no matter the order of the ip pool `spec.Addresses` Co-authored-by: Christian Ang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to declare an InClusterIPPool like the following example:
This PR also adds the addresses printcolumn to the InClusterIPPool resource, like this example:
This PR does not address the missing subnet nor First and Last columns.
This PR adds a test to ensure the controller allocates the lowest available IP in a given IP Pool.
This PR works towards some of the topics in Issue #71