🐛 Add reconciler watch for when pool capacity becomes available #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
flawedmatrix
force-pushed
the
trigger-stuck-claims-on-deletes
branch
from
17193ac to
87185c3
Compare
schrej
reviewed
May 15, 2024
|
|
||
| // Sleep 5 seconds to give the reconciler time to stop retrying | ||
| // on the newly created claim. | ||
| time.Sleep(5 * time.Second) |
There was a problem hiding this comment.
not ideal, but I guess there is no other way
There was a problem hiding this comment.
Yeah I didn't want to add this either but it wouldn't reproduce the issue otherwise.
schrej
approved these changes
May 15, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flawedmatrix, schrej The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
schrej
reviewed
May 15, 2024
|
Will need to be rebased after #250 is in for the tests to pass. |
Signed-off-by: Edwin Xie <[email protected]>
Signed-off-by: Edwin Xie <[email protected]>
And explicitly do not check return value in test function deleteClaimUnchecked Signed-off-by: Edwin Xie <[email protected]>
flawedmatrix
force-pushed
the
trigger-stuck-claims-on-deletes
branch
from
9316cfc to
794ebb2
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds a watch to the IPAddressClaim reconciler to allow it to progress claims that are still waiting for an available IP address when free addresses become available in the pool. It accomplishes this by adding a predicate only in the case where Free addresses in the Pool status are increased from 0.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #179