-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Bump sigs.k8s.io/cluster-api from 1.4.1 to 1.6.0 #219
🌱 Bump sigs.k8s.io/cluster-api from 1.4.1 to 1.6.0 #219
Conversation
Welcome @alexandrevilain! |
e96afe0
to
533b0e6
Compare
PR has been updated, some tests were failing due to the new API version. |
533b0e6
to
f656d1d
Compare
Hi @schrej ! |
Hah, yesterday evening I wanted to start working on the 1.6 upgrade and went to find my PR for 1.5 to get the branch name, and then saw your PR. I started to work on fixing the tests and continued this morning, pushed, and then noticed you've already fixed it as well 😄 Thank you! /lgtm Not sure why the linter is not running properly, it's fine locally now. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexandrevilain, schrej The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@alexandrevilain ah, that seems to have done the trick. Was on that version locally as well 🤦 merci! /lgtm |
What this PR does / why we need it:
Bump ClusterAPI to v1.6.0 to support ipam v1beta1 API. When upgrading CAPI dependency it updated controller-runtime too. This makes the codebase compatible with latest controller-runtime breaking changes.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #218