Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Bump sigs.k8s.io/cluster-api from 1.4.1 to 1.6.0 #219

Merged

Conversation

alexandrevilain
Copy link
Contributor

What this PR does / why we need it:

Bump ClusterAPI to v1.6.0 to support ipam v1beta1 API. When upgrading CAPI dependency it updated controller-runtime too. This makes the codebase compatible with latest controller-runtime breaking changes.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #218

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 4, 2024
@k8s-ci-robot k8s-ci-robot requested review from schrej and srm09 January 4, 2024 14:46
@k8s-ci-robot
Copy link
Contributor

Welcome @alexandrevilain!

It looks like this is your first PR to kubernetes-sigs/cluster-api-ipam-provider-in-cluster 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-ipam-provider-in-cluster has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 4, 2024
@alexandrevilain alexandrevilain force-pushed the feat/support-capi-1.6.0 branch from e96afe0 to 533b0e6 Compare January 5, 2024 08:51
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 5, 2024
@alexandrevilain
Copy link
Contributor Author

PR has been updated, some tests were failing due to the new API version.

@alexandrevilain alexandrevilain force-pushed the feat/support-capi-1.6.0 branch from 533b0e6 to f656d1d Compare January 5, 2024 09:02
@alexandrevilain
Copy link
Contributor Author

Hi @schrej !
Thanks for helping with the linter!
Maybe we can try upgrading golangci-lint version defined here: https://github.com/kubernetes-sigs/cluster-api-ipam-provider-in-cluster/pull/219/files#diff-07d34da07a494684d43f3913691db42dcba222ed24f5f1b7eff47eb3d1fc8ee6R21 to v1.55.2 ? :)

@schrej
Copy link
Member

schrej commented Jan 5, 2024

Hah, yesterday evening I wanted to start working on the 1.6 upgrade and went to find my PR for 1.5 to get the branch name, and then saw your PR. I started to work on fixing the tests and continued this morning, pushed, and then noticed you've already fixed it as well 😄

Thank you!

/lgtm
/approve

Not sure why the linter is not running properly, it's fine locally now.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexandrevilain, schrej

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 5, 2024
@schrej
Copy link
Member

schrej commented Jan 5, 2024

@alexandrevilain ah, that seems to have done the trick. Was on that version locally as well 🤦

merci!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit 1d47354 into kubernetes-sigs:main Jan 5, 2024
5 checks passed
@alexandrevilain alexandrevilain deleted the feat/support-capi-1.6.0 branch January 5, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ipam provider does not support capi v1.6.0
3 participants