🌱 Refactor controller tests #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
needs-rebase
adobley
changed the title
flawedmatrix
force-pushed
the
refactor-tests
branch
from
f8589b3 to
cb8867b
Compare
k8s-ci-robot
removed
the
needs-rebase
flawedmatrix
force-pushed
the
refactor-tests
branch
from
cb8867b to
1992067
Compare
k8s-ci-robot
added
the
needs-rebase
extract function to create claims assert on the IPAddress's Spec.Address field in some cases where testing the entire IPAddress is excessive Co-authored-by: Edwin Xie <[email protected]> Co-authored-by: Aidan Obley <[email protected]>
k8s-ci-robot
added
size/XL
|
Much more readable, thank you! |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adobley, schrej The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We felt it would be good to clean up some tests and make them more readable/maintainable. Let us know what you think!
We have based this on the work in #171 assuming that it will merge first.