🐛 Update cluster paused detection #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/invalid-commit-message
k8s-ci-robot
added
the
size/L
Clusters can be paused by annotation or by spec.paused. If either are true, skip claim reconcilliation that are associated to those claims. Co-authored-by: Tyler Schultz <[email protected]>
flawedmatrix
force-pushed
the
cluster-paused-detection
branch
from
0c005de to
4ca0d89
Compare
k8s-ci-robot
removed
the
do-not-merge/invalid-commit-message
|
I worked on this commit, so I should recuse myself. But, FWIW, LGTM! |
schrej
approved these changes
Jul 13, 2023
| @@ -1641,9 +1641,10 @@ var _ = Describe("IPAddressClaimReconciler", func() { | |||
| }) | |||
| }) | |||
|
|
|||
| Context("When the cluster is paused and the ipaddressclaim has the cluster-name label", func() { | |||
| Context("When the cluster is spec.paused true and the ipaddressclaim has the cluster-name label", func() { | |||
There was a problem hiding this comment.
FYI: you could also use When() here instead. In general Context, Describe and When are equivalent.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flawedmatrix, schrej The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Clusters can be paused by annotation or by spec.paused. If either are true, skip claim reconcilliation that are associated to those claims.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #136