protect pools with IP allocations from deletion #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christianang
force-pushed
the
guard-pool-deletion
branch
2 times, most recently
from
1bd8b63 to
fbceb13
Compare
|
#116 is in now! |
- this finalizer will prevent the pool from being deleted if there are existing ipaddresses from the pool Co-authored-by: Edwin Xie <[email protected]>
flawedmatrix
force-pushed
the
guard-pool-deletion
branch
from
fbceb13 to
bca3ee7
Compare
checks for any ipaddresses allocated from the pool before allowing deletion in the delete webhook Co-authored-by: Christian Ang <[email protected]>
flawedmatrix
force-pushed
the
guard-pool-deletion
branch
from
bca3ee7 to
9c880ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a finalizer to prevent pool deletion when IPs are still allocated
Adds a delete webhook check that will ensure pools with allocated IPs cannot be removed
This change relies on work in #116, when that is merged we can rebase this.
Fixes #114