fix: Use the dynamic client in the InventoryClient #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
approved
ash2k
suggested changes
Jan 23, 2022
k8s-ci-robot
added
the
needs-rebase
mortent
force-pushed
the
UseDynamicClientInInventoryClient
branch
from
6ea9c66 to
ceef78a
Compare
k8s-ci-robot
removed
the
needs-rebase
mortent
force-pushed
the
UseDynamicClientInInventoryClient
branch
from
ceef78a to
aebd70b
Compare
seans3
approved these changes
Jan 24, 2022
k8s-ci-robot
added
the
lgtm
mortent
force-pushed
the
UseDynamicClientInInventoryClient
branch
from
aebd70b to
8325b7f
Compare
k8s-ci-robot
removed
the
lgtm
|
/retest |
1 similar comment
|
/retest |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ash2k, mortent, seans3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the InventoryClient implementation to use the dynamic client, rather than the builder and info functionality. It means we don't have to use the
resource.Infotypes, which removes the need for theInfoHelperin the InventoryClient. The dynamic client is also easier to work with and comes with aFakeDynamicClientimplementation that is easier to use than stubbing out the REST api through the TestFactory.