Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Make UnknownTypesError error more readable #479

Merged
merged 1 commit into from
Nov 13, 2021
Merged

fix: Make UnknownTypesError error more readable #479

merged 1 commit into from
Nov 13, 2021

Conversation

karlkfi
Copy link
Contributor

@karlkfi karlkfi commented Nov 12, 2021 •
edited
Loading

  • Fix regression from switch to GroupVersionKind from GroupKind
  • New error string format: G/V/K, G/V/K
  • Avoid K.G/V, which looks like but isn't R.G/V

Fixes: #430 (comment)

@karlkfi
fix: Make UnknownTypesError error more readable
c5452a8 
- Fix regression from switch to GroupVersionKind from GroupKind
- New error string format: G/V/K, G/V/K
- Avoid K.G/V, which looks like but isn't R.G/V
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 12, 2021
@karlkfi karlkfi mentioned this pull request Nov 12, 2021
Merged
@k8s-ci-robot k8s-ci-robot requested review from ash2k and seans3 November 12, 2021 19:30
@karlkfi karlkfi mentioned this pull request Nov 12, 2021
Closed
mortent
mortent approved these changes Nov 12, 2021
View reviewed changes
Copy link
Member

@mortent mortent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2021
ash2k
ash2k approved these changes Nov 13, 2021
View reviewed changes
Copy link
Member

@ash2k ash2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ash2k, karlkfi, mortent

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 45a0b5b into kubernetes-sigs:master Nov 13, 2021
@karlkfi karlkfi deleted the karl-error-string branch November 13, 2021 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mortent mortent mortent approved these changes

@ash2k ash2k ash2k approved these changes

@seans3 seans3 Awaiting requested review from seans3

Assignees

@ash2k ash2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@karlkfi @k8s-ci-robot @mortent @ash2k