Skip to content

Commit

Permalink
chore: Rename fake.FakeClusterReader to fake.ClusterReader
Browse files Browse the repository at this point in the history
  • Loading branch information
karlkfi committed Feb 15, 2022
1 parent 94c0b1c commit f265615
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
8 changes: 4 additions & 4 deletions pkg/kstatus/polling/clusterreader/fake/fake.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import (
"sigs.k8s.io/controller-runtime/pkg/client"
)

type FakeClusterReader struct {
type ClusterReader struct {
NoopClusterReader

GetResource *unstructured.Unstructured
Expand All @@ -23,21 +23,21 @@ type FakeClusterReader struct {
SyncErr error
}

func (f *FakeClusterReader) Get(_ context.Context, _ client.ObjectKey, u *unstructured.Unstructured) error {
func (f *ClusterReader) Get(_ context.Context, _ client.ObjectKey, u *unstructured.Unstructured) error {
if f.GetResource != nil {
u.Object = f.GetResource.Object
}
return f.GetErr
}

func (f *FakeClusterReader) ListNamespaceScoped(_ context.Context, list *unstructured.UnstructuredList, _ string, _ labels.Selector) error {
func (f *ClusterReader) ListNamespaceScoped(_ context.Context, list *unstructured.UnstructuredList, _ string, _ labels.Selector) error {
if f.ListResources != nil {
list.Items = f.ListResources.Items
}
return f.ListErr
}

func (f *FakeClusterReader) Sync(_ context.Context) error {
func (f *ClusterReader) Sync(_ context.Context) error {
return f.SyncErr
}

Expand Down
2 changes: 1 addition & 1 deletion pkg/kstatus/polling/engine/engine_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ func TestNewStatusPollerRunnerCancellationWithMultipleResources(t *testing.T) {
engine := PollerEngine{
Mapper: fakeMapper,
ClusterReaderFactory: ClusterReaderFactoryFunc(func(client.Reader, meta.RESTMapper, object.ObjMetadataSet) (ClusterReader, error) {
return &fakecr.FakeClusterReader{
return &fakecr.ClusterReader{
SyncErr: context.Canceled,
}, nil
}),
Expand Down
4 changes: 2 additions & 2 deletions pkg/kstatus/polling/statusreaders/common_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ func TestLookupResource(t *testing.T) {

for tn, tc := range testCases {
t.Run(tn, func(t *testing.T) {
fakeReader := &fakecr.FakeClusterReader{
fakeReader := &fakecr.ClusterReader{
GetErr: tc.readerErr,
}
fakeMapper := fakemapper.NewFakeRESTMapper(deploymentGVK)
Expand Down Expand Up @@ -201,7 +201,7 @@ spec:

for tn, tc := range testCases {
t.Run(tn, func(t *testing.T) {
fakeClusterReader := &fakecr.FakeClusterReader{
fakeClusterReader := &fakecr.ClusterReader{
ListResources: &unstructured.UnstructuredList{
Items: tc.listObjects,
},
Expand Down
2 changes: 1 addition & 1 deletion pkg/kstatus/polling/statusreaders/deployment_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ func TestReadStatus(t *testing.T) {
for tn := range testCases {
tc := testCases[tn]
t.Run(tn, func(t *testing.T) {
fakeReader := &fakecr.FakeClusterReader{
fakeReader := &fakecr.ClusterReader{
GetResource: tc.readerResource,
GetErr: tc.readerErr,
}
Expand Down

0 comments on commit f265615

Please sign in to comment.