listener status update #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlavacca
force-pushed
the
listener-status
branch
from
d219f0d to
08c0742
Compare
mlavacca
force-pushed
the
listener-status
branch
from
08c0742 to
448fda2
Compare
Copied (with git history): controllers/gateway_controller.go — into: — controllers/gateway_controller_status.go
Copied (with git history): controllers/gateway_controller.go — into: — controllers/gateway_controller_status.go
controllers/gateway_controller.go — into: — controllers/gateway_controller_status.go
Copied (with git history): controllers/gateway_controller.go — into: — controllers/gateway_controller_utils.go
Copied (with git history): controllers/gateway_controller.go — into: — controllers/gateway_controller_utils.go
controllers/gateway_controller.go — into: — controllers/gateway_controller_utils.go
Signed-off-by: Mattia Lavacca <[email protected]>
mlavacca
force-pushed
the
listener-status
branch
from
448fda2 to
63c3234
Compare
Signed-off-by: Mattia Lavacca <[email protected]>
Signed-off-by: Mattia Lavacca <[email protected]>
Signed-off-by: Mattia Lavacca <[email protected]>
Signed-off-by: Mattia Lavacca <[email protected]>
mlavacca
force-pushed
the
listener-status
branch
from
b6aca65 to
19dd619
Compare
shaneutt
requested changes
Dec 5, 2022
There was a problem hiding this comment.
Mostly looking good to me, I really appreciate the effort into testing the controller here.
My comments are mostly minor things, and mainly about some of the indirection going on in the reconciler. In general I would like to see us follow the practice more of "check a condition, take an action if needed, and requeue" instead of checking conditions, and carrying them forward as state for later decisions.
Co-authored-by: Shane Utt <[email protected]> Signed-off-by: Mattia Lavacca <[email protected]>
mlavacca
force-pushed
the
listener-status
branch
2 times, most recently
from
2964fa1 to
c20d6dc
Compare
Signed-off-by: Mattia Lavacca <[email protected]>
mlavacca
force-pushed
the
listener-status
branch
from
c20d6dc to
96109c2
Compare
shaneutt
approved these changes
Dec 7, 2022
shaneutt
added a commit
to shaneutt/blixt
that referenced
this pull request
Oct 11, 2023
Signed-off-by: Mattia Lavacca <[email protected]> Co-authored-by: Shane Utt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial scaffolding to enforce the Gateway listener status.
Fixes #13