Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] Patched sidecars #2370

Closed

Conversation

AndrewSirenko
Copy link
Contributor

What type of PR is this?

What is this PR about? / Why do we need it?

/hold

Test pr to test new sidecars

How was this change tested?

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 27, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from andrewsirenko. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 27, 2025
Copy link

Code Coverage Diff

This PR does not change the code coverage

@AndrewSirenko AndrewSirenko changed the title [TEST] test patched sidecars [TEST] Patched sidecars Feb 27, 2025
@k8s-ci-robot
Copy link
Contributor

@AndrewSirenko: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-aws-ebs-csi-driver-verify 30d50f6 link true /test pull-aws-ebs-csi-driver-verify
pull-aws-ebs-csi-driver-external-test-arm64 30d50f6 link false /test pull-aws-ebs-csi-driver-external-test-arm64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@AndrewSirenko
Copy link
Contributor Author

/close

Sidecar releases have been approved

@k8s-ci-robot
Copy link
Contributor

@AndrewSirenko: Closed this PR.

In response to this:

/close

Sidecar releases have been approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants