-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Helm] Fix issue with enabled flag handling when used as a subchart #2359
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @sm43! |
Hi @sm43. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
0c99f72
to
02b7147
Compare
02b7147
to
75805f3
Compare
/ok-to-test Hey @sm43, Thanks for the PR! Can you can attach a gist with reproduction steps for how you tested aws-ebs-csi-driver as subchart before and after this PR to your PR description? |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
closing this as #2361 adds the change required. Thanks! |
What type of PR is this?
/kind bug
What is this PR about? / Why do we need it?
This PR fixes an issue where the enabled flag was not being correctly processed when the AWS EBS CSI Driver was used as a subchart.
Error during upgrade
we reference the chart as
For example:
Open Telemetry Helm chart handles it similar way
https://github.com/open-telemetry/opentelemetry-helm-charts/blob/a20fc37bb9cc96dbd146c2d5ab442982ae24a4c0/charts/opentelemetry-collector/values.schema.json#L19
How was this change tested?
Does this PR introduce a user-facing change?