Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

WIP: Define default binding params on plans #2435

Closed
wants to merge 6 commits into from
Closed

WIP: Define default binding params on plans #2435

wants to merge 6 commits into from

Conversation

carlory
Copy link
Contributor

@carlory carlory commented Oct 24, 2018 •
edited
Loading

This PR is a

  • Feature Implementation
  • Bug Fix
  • Documentation

What this PR does / why we need it:

Similar to how we added DefaultProvisionParameters to plans in #2282, we also want the same type of functionality but for the parameters on ServiceBinding resources.

Which issue(s) this PR fixes

Fixes #2348

Please leave this checklist in the PR comment so that maintainers can ensure a good PR.

Merge Checklist:

  • New feature
    • Tests
    • Documentation
  • SVCat CLI flag
  • Server Flag for config
    • Chart changes
    • removing a flag by marking deprecated and hiding to avoid
      breaking the chart release and existing clients who provide a
      flag that will get an error when they try to update

TODO:

  • reconcile binding and default params
  • add test codes
  • add docs

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 24, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: kibbles-n-bytes

If they are not already assigned, you can assign the PR to them by writing /assign @kibbles-n-bytes in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 24, 2018
@luksa
Copy link
Contributor

luksa commented Oct 25, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 25, 2018
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 25, 2018
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 26, 2018
@carlory
Merge branch 'master' of https://github.com/kubernetes-incubator/serv…
9e2a0fc 
…ice-catalog into default-plan-bind-parameters

# Conflicts:
#	pkg/apis/servicecatalog/v1beta1/zz_generated.deepcopy.go
#	pkg/apis/servicecatalog/zz_generated.deepcopy.go
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 26, 2018
@carlory carlory mentioned this pull request Nov 14, 2018
Closed
@k8s-ci-robot
Copy link
Contributor

@carlory: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 20, 2019
@jberkhahn
Copy link
Contributor

Due to lack of activity, we're closing this. If you still have an interest in this, please reopen with these changes.

@jberkhahn jberkhahn closed this Apr 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jboyd01 jboyd01 Awaiting requested review from jboyd01

@staebler staebler Awaiting requested review from staebler

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add DefaultBindParameters to plans
4 participants
@carlory @k8s-ci-robot @luksa @jberkhahn