-
Notifications
You must be signed in to change notification settings - Fork 294
feat: Fine-grained stack update #1233
feat: Fine-grained stack update #1233
Conversation
core/root/cluster.go
Outdated
@@ -237,51 +249,103 @@ func (c clusterImpl) Info() (*Info, error) { | |||
return describer.Info() | |||
} | |||
|
|||
func (c clusterImpl) prepareTemplateWithAssets() (string, error) { | |||
assets, err := c.Assets() | |||
func (c clusterImpl) generateAssets(targets OperationTargets) (cfnstack.Assets, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is where the magic happens.
Codecov Report
@@ Coverage Diff @@
## master #1233 +/- ##
=========================================
- Coverage 36.63% 36.23% -0.4%
=========================================
Files 63 64 +1
Lines 3882 3913 +31
=========================================
- Hits 1422 1418 -4
- Misses 2242 2279 +37
+ Partials 218 216 -2
Continue to review full report at Codecov.
|
This is triggering a considerable amount of refactorings... 😉 |
Vendor changes is separated and follows for the ease of reviews
fdf2719
to
27de2a2
Compare
You now have to enumerate node pools explicitly like Also note that |
fa009a6
to
42d501a
Compare
42d501a
to
0cc0ae4
Compare
Go ahead! |
Is this intended to work with just |
USAGE:
Update all the stacks including root, control-plane, worker:
kube-aws update --force
Update the control-plane stack only:
kube-aws update --targets control-plane --force
Note that, for the root stack, just the
Resources.Controlplane.Properties.TemplateURL
is updated in this case.Update the worker node pool stack(s) only:
kube-aws update --targets worker --force
NOTES:
root
stack is updated implicitly when you update all the stacks includingworker
,control-plane
,etcd
andnetwork
TODO:
rollbackOnFailure
for control-plane and etcd stack onlyEverything else should be there
Ref #1112