-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/assign @jsafrane |
Please follow the pattern here https://github.com/kubernetes-incubator/external-storage/pull/612/files#diff-16daa5c3f02eee06add7f1af0a3fa901L234 to make it an optional arg e.g. something like func Namer(namer Namer) func(*ProvisionController) error {
return func(c *ProvisionController) error {
if c.HasRun() {
return errRuntime
}
c.namer = namer
return nil
}
} this is just so not everyone has to add Otherwise the code lgtm I am actually unsure about whether we should let authors name the pvc however they want or enforce a suffix |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
For some providers, there have limitations on volume name. e.g. for
Linode
, maximum length of the volume name is 32 characters (Length of default namer is 40 characters). So, this interface will help those providers to use own namer.