Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependency go modules for k8s v1.28.0 #203

Merged
merged 3 commits into from
Sep 7, 2023
Merged

Update dependency go modules for k8s v1.28.0 #203

merged 3 commits into from
Sep 7, 2023

Conversation

Sneha-at
Copy link
Contributor

@Sneha-at Sneha-at commented Aug 17, 2023 •
edited by msau42
Loading

Ran kubernetes-csi/csi-release-tools go-get-kubernetes.sh -p 1.28.0

Update kubernetes dependencies to v1.28.0

@Sneha-at
Squashed 'release-tools/' changes from 1df23db..de2fba8
753067a 
de2fba8 Merge pull request kubernetes-csi#233 from andyzhangx/andyzhangx-patch-1
cee895e remove windows 20H2 build since it's EOL long time ago
670bb0e Merge pull request kubernetes-csi#229 from marosset/fix-codespell-errors
35d5e78 Merge pull request kubernetes-csi#219 from yashsingh74/update-registry
63473cc Merge pull request kubernetes-csi#231 from coulof/bump-go-version-1.20.5
29a5c76 Merge pull request kubernetes-csi#228 from mowangdk/chore/adopt_kubernetes_recommand_labels
8dd2821 Update cloudbuild image with go 1.20.5
2b8b80e fixing some codespell errors
72984ec chore: adopt kubernetes recommand label
901bcb5 Update registry k8s.gcr.io -> registry.k8s.io

git-subtree-dir: release-tools
git-subtree-split: de2fba88becec7dec6744355a8ddb0057c5fe2f9
@Sneha-at
Merge commit '753067a40093ea7742925119f916dbfc65ae99af' into module-u…
da2c9f8 
…pdate-master
@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 17, 2023
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 17, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @Sneha-at. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 17, 2023
@sunnylovestiramisu
Copy link
Contributor

/okay-to-test

@Sneha-at Sneha-at force-pushed the module-update-master branch from 0bc0947 to a3afa62 Compare August 17, 2023 16:52
@Sneha-at Sneha-at mentioned this pull request Aug 17, 2023
Closed
9 tasks
@sunnylovestiramisu
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 18, 2023
@Sneha-at
Copy link
Contributor Author

Sneha-at commented Aug 18, 2023 •
edited
Loading

/release-note-none

1 similar comment
@Sneha-at
Copy link
Contributor Author

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 18, 2023
sunnylovestiramisu
sunnylovestiramisu reviewed Aug 18, 2023
View reviewed changes
@Sneha-at Sneha-at force-pushed the module-update-master branch from a3afa62 to 2c28f46 Compare August 24, 2023 19:58
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Sep 6, 2023
@Sneha-at Sneha-at force-pushed the module-update-master branch from 2c28f46 to 5c75b02 Compare September 6, 2023 17:53
@Sneha-at
Copy link
Contributor Author

Sneha-at commented Sep 6, 2023

Updated this to csi-lib-utils: v0.14.0 for this release as there is otel dependency issue @jsafrane

@jsafrane
Copy link
Contributor

jsafrane commented Sep 7, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 7, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, Sneha-at

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2023
@k8s-ci-robot k8s-ci-robot merged commit 90c3a1d into kubernetes-csi:master Sep 7, 2023
@mpatlasov mpatlasov mentioned this pull request Oct 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsafrane jsafrane jsafrane left review comments

@sunnylovestiramisu sunnylovestiramisu sunnylovestiramisu left review comments

@mauriciopoppe mauriciopoppe Awaiting requested review from mauriciopoppe

Assignees

@jsafrane jsafrane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sneha-at @k8s-ci-robot @sunnylovestiramisu @jsafrane