Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct snapshot controller installation doc #529

Merged
merged 1 commit into from
Jun 10, 2021

Conversation

humblec
Copy link
Contributor

@humblec humblec commented Jun 10, 2021

At present the snapshot readme guide point out the snapshot beta CRD installation. However as we have moved to GA version of snapshot CRD, we dont need the references in the readme file to Beta CRD. This PR address the same.

Signed-off-by: Humble Chirammal [email protected]

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 10, 2021
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 10, 2021
@humblec
Copy link
Contributor Author

humblec commented Jun 10, 2021

/assign @xing-yang

@humblec
Copy link
Contributor Author

humblec commented Jun 10, 2021

/assign @xing-yang

@xing-yang
Copy link
Collaborator

Can you fix the PR description at the top?

Signed-off-by: Humble Chirammal <[email protected]>
@humblec humblec changed the title Point out GA CRD installation instead of beta CRD correct snapshot controller installation doc Jun 10, 2021
@humblec
Copy link
Contributor Author

humblec commented Jun 10, 2021

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jun 10, 2021
@xing-yang
Copy link
Collaborator

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 10, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: humblec, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2021
@k8s-ci-robot k8s-ci-robot merged commit a06aa19 into kubernetes-csi:master Jun 10, 2021
@xing-yang
Copy link
Collaborator

@humblec The following in the release note section in the PR description is causing an error when generating release notes automatically:
```release-note-none

```
It should be like this:
```release-note
NONE
```

@humblec
Copy link
Contributor Author

humblec commented Aug 13, 2021

Sorry @xing-yang, it was a typo, corrected it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants