-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change image pullpolicy from Always to IfNotPresent #357
change image pullpolicy from Always to IfNotPresent #357
Conversation
Hi @Madhu-1. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @xing-yang |
I think our hostpath CSI driver deployment scripts all use "Always" to make sure the image is the latest. So we should be consistent here. |
Even the external-provisioner deployment https://github.com/kubernetes-csi/external-provisioner/blob/321fa5c1c951f1446a91789792c25220fe1c1840/deploy/kubernetes/deployment.yaml#L29 is also set to IfNotPresent |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
/ok-to-test |
We now actually need to use "IfNotPresent" to deploy snapshot-controller using a local image in prow.sh. So I'm going to merge this. Thanks! |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Madhu-1, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
currently, image pull policy is set to Always, if the pod restarts the image will be always pulled even if its present, changing
the pull policy will speed up the pod creation.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: