Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add workaround for hack/update-generated-code.sh #265

Merged
merged 1 commit into from
Mar 22, 2020
Merged

doc: add workaround for hack/update-generated-code.sh #265

merged 1 commit into from
Mar 22, 2020

Conversation

alex1989hu
Copy link
Contributor

**What type of PR is this?
/kind documentation

What this PR does / why we need it:
Add missing workaround to hack/update-generated-code.sh

Which issue(s) this PR fixes:
Fixes #239

Special notes for your reviewer:
As per reviewer's request #239 (comment), added the steps to let users to use update-generated-code.sh..
Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 4, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @alex1989hu. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 4, 2020
@k8s-ci-robot k8s-ci-robot requested review from lpabon and xing-yang March 4, 2020 21:24
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 4, 2020
@alex1989hu
doc: add workaround for hack/update-generated-code.sh
14eaac2 
code-generator incorrectly resolve package path: wants to
write into v2/ directory instead of resolving v2 as package
path

Provide steps to successfully execute code-generator

Signed-off-by: Alex Szakaly <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Mar 4, 2020
@alex1989hu
Copy link
Contributor Author

/assign @yuxiangqian

@xing-yang
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 4, 2020
@yuxiangqian
Copy link
Contributor

some nits and lgtm.
@alex1989hu what would be the path forward? should we re-org the whole repo and copy files into v2?

@alex1989hu
Copy link
Contributor Author

some nits and lgtm.
@alex1989hu what would be the path forward? should we re-org the whole repo and copy files into v2?

The long term goal is to drop Go dep compatibility - the reason why we had to create a v2 directory is to being compatible with. If we drop the compatibility, then we can remove v2 directory at the same time.

xing-yang
xing-yang reviewed Mar 8, 2020
View reviewed changes
hack/README.md
@@ -10,7 +10,35 @@ This is the script to update clientset/informers/listers and API deepcopy code u

Make sure to run this script after making changes to /pkg/apis/volumesnapshot/v1beta1/types.go.

To run this script, simply run: ./hack/update-generated-code.sh from the project root directory.
To run this script, you have to patch it:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some words here to explain why we have to go thru these steps to generate code and reference this issue #239.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to merged this PR.
@alex1989hu can you submit a followup PR to address this comment.

@xing-yang
Copy link
Collaborator

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 22, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alex1989hu, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2020
@k8s-ci-robot k8s-ci-robot merged commit 505542b into kubernetes-csi:master Mar 22, 2020
TerryHowe added a commit to TerryHowe/external-snapshotter that referenced this pull request Dec 6, 2024
@TerryHowe
Squashed 'release-tools/' changes from e31de525..734c2b95
df19438 
734c2b95 Merge pull request kubernetes-csi#265 from Rakshith-R/consider-main-branch
f95c855b Merge pull request kubernetes-csi#262 from huww98/golang-toolchain
3c8d966f Treat main branch as equivalent to master branch
6b05f0fc use new GOTOOLCHAIN env to manage go version

git-subtree-dir: release-tools
git-subtree-split: 734c2b950c4b31f64b63052c64ffa5929d1c9b97
TerryHowe added a commit to TerryHowe/external-snapshotter that referenced this pull request Dec 9, 2024
@TerryHowe
Squashed 'release-tools/' changes from e31de525b..98f23071d
5e9e941 
98f23071d Merge pull request kubernetes-csi#260 from TerryHowe/update-csi-driver-version
e9d8712d0 Merge pull request kubernetes-csi#259 from stmcginnis/deprecated-kind-kube-root
faf79ff66 Remove --kube-root deprecated kind argument
734c2b950 Merge pull request kubernetes-csi#265 from Rakshith-R/consider-main-branch
f95c855be Merge pull request kubernetes-csi#262 from huww98/golang-toolchain
3c8d966fe Treat main branch as equivalent to master branch
6b05f0fcc use new GOTOOLCHAIN env to manage go version
18b6ac6d2 chore: update CSI driver version to 1.15

git-subtree-dir: release-tools
git-subtree-split: 98f23071d946dd3de3188a7e1f84679067003162
@xing-yang xing-yang mentioned this pull request Dec 9, 2024
Open
AndrewSirenko added a commit to AndrewSirenko/external-snapshotter that referenced this pull request Dec 10, 2024
@AndrewSirenko
Squashed 'release-tools/' changes from 988496a1..98f23071
27d661c 
98f23071 Merge pull request kubernetes-csi#260 from TerryHowe/update-csi-driver-version
e9d8712d Merge pull request kubernetes-csi#259 from stmcginnis/deprecated-kind-kube-root
faf79ff6 Remove --kube-root deprecated kind argument
734c2b95 Merge pull request kubernetes-csi#265 from Rakshith-R/consider-main-branch
f95c855b Merge pull request kubernetes-csi#262 from huww98/golang-toolchain
3c8d966f Treat main branch as equivalent to master branch
e31de525 Merge pull request kubernetes-csi#261 from huww98/golang
fd153a9e Bump golang to 1.23.1
a8b3d050 pull-test.sh: fix "git subtree pull" errors
6b05f0fc use new GOTOOLCHAIN env to manage go version
18b6ac6d chore: update CSI driver version to 1.15
227577e0 Merge pull request kubernetes-csi#258 from gnufied/enable-race-detection
e1ceee28 Always enable race detection while running tests

git-subtree-dir: release-tools
git-subtree-split: 98f23071d946dd3de3188a7e1f84679067003162
AndrewSirenko added a commit to AndrewSirenko/external-snapshotter that referenced this pull request Dec 10, 2024
@AndrewSirenko
Squashed 'release-tools/' changes from 988496a1..406a79ac
e2595d3 
406a79ac Merge pull request kubernetes-csi#267 from huww98/gomodcache
9cec273d Set GOMODCACHE to avoid re-download toolchain
98f23071 Merge pull request kubernetes-csi#260 from TerryHowe/update-csi-driver-version
e9d8712d Merge pull request kubernetes-csi#259 from stmcginnis/deprecated-kind-kube-root
faf79ff6 Remove --kube-root deprecated kind argument
734c2b95 Merge pull request kubernetes-csi#265 from Rakshith-R/consider-main-branch
f95c855b Merge pull request kubernetes-csi#262 from huww98/golang-toolchain
3c8d966f Treat main branch as equivalent to master branch
e31de525 Merge pull request kubernetes-csi#261 from huww98/golang
fd153a9e Bump golang to 1.23.1
a8b3d050 pull-test.sh: fix "git subtree pull" errors
6b05f0fc use new GOTOOLCHAIN env to manage go version
18b6ac6d chore: update CSI driver version to 1.15
227577e0 Merge pull request kubernetes-csi#258 from gnufied/enable-race-detection
e1ceee28 Always enable race detection while running tests

git-subtree-dir: release-tools
git-subtree-split: 406a79acf021b5564108afebeea7d0ed44648d3f
TerryHowe added a commit to TerryHowe/external-snapshotter that referenced this pull request Dec 11, 2024
@TerryHowe
Squashed 'release-tools/' changes from e31de525b..406a79acf
8117c97 
406a79acf Merge pull request kubernetes-csi#267 from huww98/gomodcache
9cec273d8 Set GOMODCACHE to avoid re-download toolchain
98f23071d Merge pull request kubernetes-csi#260 from TerryHowe/update-csi-driver-version
e9d8712d0 Merge pull request kubernetes-csi#259 from stmcginnis/deprecated-kind-kube-root
faf79ff66 Remove --kube-root deprecated kind argument
734c2b950 Merge pull request kubernetes-csi#265 from Rakshith-R/consider-main-branch
f95c855be Merge pull request kubernetes-csi#262 from huww98/golang-toolchain
3c8d966fe Treat main branch as equivalent to master branch
6b05f0fcc use new GOTOOLCHAIN env to manage go version
18b6ac6d2 chore: update CSI driver version to 1.15

git-subtree-dir: release-tools
git-subtree-split: 406a79acf021b5564108afebeea7d0ed44648d3f
rhrmo added a commit to rhrmo/external-snapshotter that referenced this pull request Dec 17, 2024
@rhrmo
Squashed 'release-tools/' changes from e31de525..04965932
9722c1a 
04965932 Merge pull request kubernetes-csi#268 from huww98/cloudbuild
119aee1f Merge pull request kubernetes-csi#266 from jsafrane/bump-sanity-5.3.1
0ae5e52d Update cloudbuild image with go 1.21+
406a79ac Merge pull request kubernetes-csi#267 from huww98/gomodcache
9cec273d Set GOMODCACHE to avoid re-download toolchain
98f23071 Merge pull request kubernetes-csi#260 from TerryHowe/update-csi-driver-version
e9d8712d Merge pull request kubernetes-csi#259 from stmcginnis/deprecated-kind-kube-root
faf79ff6 Remove --kube-root deprecated kind argument
734c2b95 Merge pull request kubernetes-csi#265 from Rakshith-R/consider-main-branch
43bde065 Bump csi-sanity to 5.3.1
f95c855b Merge pull request kubernetes-csi#262 from huww98/golang-toolchain
3c8d966f Treat main branch as equivalent to master branch
6b05f0fc use new GOTOOLCHAIN env to manage go version
18b6ac6d chore: update CSI driver version to 1.15

git-subtree-dir: release-tools
git-subtree-split: 04965932661b6e62709dcdbb9c25da528bac2605
@rhrmo rhrmo mentioned this pull request Dec 17, 2024
Merged
AndrewSirenko added a commit to AndrewSirenko/external-snapshotter that referenced this pull request Feb 26, 2025
@AndrewSirenko
Squashed 'release-tools/' changes from e31de525b..90efb2ca5
2ec74dc 
90efb2ca5 Merge pull request kubernetes-csi#272 from andyzhangx/patch-3
9b616fec4 Bump golang to 1.23.6 to fix CVE-2024-45336, CVE-2025-22866
049659326 Merge pull request kubernetes-csi#268 from huww98/cloudbuild
119aee1ff Merge pull request kubernetes-csi#266 from jsafrane/bump-sanity-5.3.1
0ae5e52d9 Update cloudbuild image with go 1.21+
406a79acf Merge pull request kubernetes-csi#267 from huww98/gomodcache
9cec273d8 Set GOMODCACHE to avoid re-download toolchain
98f23071d Merge pull request kubernetes-csi#260 from TerryHowe/update-csi-driver-version
e9d8712d0 Merge pull request kubernetes-csi#259 from stmcginnis/deprecated-kind-kube-root
faf79ff66 Remove --kube-root deprecated kind argument
734c2b950 Merge pull request kubernetes-csi#265 from Rakshith-R/consider-main-branch
43bde065f Bump csi-sanity to 5.3.1
f95c855be Merge pull request kubernetes-csi#262 from huww98/golang-toolchain
3c8d966fe Treat main branch as equivalent to master branch
6b05f0fcc use new GOTOOLCHAIN env to manage go version
18b6ac6d2 chore: update CSI driver version to 1.15

git-subtree-dir: release-tools
git-subtree-split: 90efb2ca59900f19eba05e65da28beda79c5bb28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xing-yang xing-yang xing-yang left review comments

@lpabon lpabon Awaiting requested review from lpabon

Assignees

@xing-yang xing-yang

@yuxiangqian yuxiangqian

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect repository layour for v2 Go Modules
4 participants
@alex1989hu @k8s-ci-robot @xing-yang @yuxiangqian