Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add changelog for v3.1.0 #686

Merged
merged 1 commit into from
Dec 18, 2021
Merged

Add changelog for v3.1.0 #686

merged 1 commit into from
Dec 18, 2021

Conversation

pohly
Copy link
Contributor

@pohly pohly commented Dec 8, 2021

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Preparation for v3.1.0 / Kubernetes 1.24.

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 8, 2021
@ggriffiths
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 8, 2021
@pohly
Copy link
Contributor Author

pohly commented Dec 9, 2021

/assign @xing-yang

For approval.

@pohly
Copy link
Contributor Author

pohly commented Dec 13, 2021

/hold

Let's include #688 in the next release.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 13, 2021
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 16, 2021
@pohly
Copy link
Contributor Author

pohly commented Dec 16, 2021

/hold cancel

All pending PRs are merged and this one was updated, we can release.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 16, 2021
@humblec
Copy link
Contributor

humblec commented Dec 17, 2021

lgtm.. Thanks !

xing-yang
xing-yang reviewed Dec 17, 2021
View reviewed changes
CHANGELOG/CHANGELOG-3.1.md Outdated
## Changes by Kind

### Feature
- Introduces `HonorPvReclaim` feature gate that ensures PV honors the Reclaim policy irrespective of deletion order. ([#679](https://github.com/kubernetes-csi/external-provisioner/pull/679), [@deepakkinni](https://github.com/deepakkinni))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is "HonorPVReclaimPolicy".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is actually wrongly mentioned in the PR release note itself :(..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed it in this PR.

@xing-yang
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 18, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pohly, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2021
@k8s-ci-robot k8s-ci-robot merged commit 3d640ea into kubernetes-csi:master Dec 18, 2021
@humblec humblec mentioned this pull request Jan 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xing-yang xing-yang xing-yang left review comments

@humblec humblec humblec left review comments

@ggriffiths ggriffiths Awaiting requested review from ggriffiths

@j-griffith j-griffith Awaiting requested review from j-griffith

Assignees

@xing-yang xing-yang

@ggriffiths ggriffiths

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pohly @ggriffiths @humblec @xing-yang @k8s-ci-robot