Bumping k8s version to 1.13.0-beta.1; Pointing to kubernetes-sigs/sig-storage-lib-external-provisioner instead of external-storage; Update CSINodeInfo schema #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
verult
force-pushed
the
update-csinodeinfo
branch
from
bae5ce0 to
bab18d8
Compare
verult
force-pushed
the
update-csinodeinfo
branch
from
bab18d8 to
06ebe4c
Compare
msau42
reviewed
Nov 20, 2018
Gopkg.toml
Outdated
| @@ -38,32 +38,33 @@ | |||
|
|
|||
| [[constraint]] | |||
| name = "github.com/kubernetes-csi/external-snapshotter" | |||
| version = "1.0.0-rc2" | |||
| #version = "1.0.0-rc2" | |||
| branch = "master" | |||
There was a problem hiding this comment.
why does this need to be master?
There was a problem hiding this comment.
Ah ok didn't realize rc3 has been cut, will update
…r lib dependency is now kubernetes-sigs/sig-storage-lib-external-provisioner
verult
force-pushed
the
update-csinodeinfo
branch
from
06ebe4c to
798b20d
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane, verult The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note for reviewers: version bump and provisioner lib change are combined into the first commit. See Gopkg.toml and all changes in
cmdandpkg.