Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update log message for help debugging #158

Merged
merged 2 commits into from
Nov 14, 2018
Merged

Update log message for help debugging #158

merged 2 commits into from
Nov 14, 2018

Conversation

leakingtapan
Copy link

I had an issue that is obscure to debug without requisite being logged when matchLabelExpressions key mismatches for allowedTopologies in storage class.

@davidz627
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 22, 2018
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Oct 22, 2018
@davidz627
Copy link
Contributor

/lgtm
/assign @jsafrane
for approval

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 22, 2018
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 22, 2018
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 28, 2018
@davidz627
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2018
@leakingtapan
Copy link
Author

@jsafrane could you approve this?

@leakingtapan
Copy link
Author

leakingtapan commented Nov 9, 2018 •
edited
Loading

@lpabon since you are the owner too, would you like too take a look?

@leakingtapan
Copy link
Author

/assign @lpabon

@jsafrane
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2018
@k8s-ci-robot k8s-ci-robot merged commit 5038544 into kubernetes-csi:master Nov 14, 2018
@leakingtapan leakingtapan deleted the add-log branch November 26, 2018 21:50
@leakingtapan leakingtapan mentioned this pull request Feb 8, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidz627 davidz627 Awaiting requested review from davidz627

@sbezverk sbezverk Awaiting requested review from sbezverk

Assignees

@jsafrane jsafrane

@lpabon lpabon

@davidz627 davidz627

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@leakingtapan @davidz627 @jsafrane @k8s-ci-robot @lpabon