Merge pull request #532 from pohly/flow-diagram

doc: UML diagram for volume creation and deletion

Makefile

@@ -16,3 +16,4 @@ CMDS=csi-provisioner
 all: build
 
 include release-tools/build.make
+include doc/doc.make

README.md

@@ -115,6 +115,13 @@ See the [storage capacity section](#capacity-support) below for details.
 
 * All glog / klog arguments are supported, such as `-v <log level>` or `-alsologtostderr`.
 
+### Design
+
+External-provisioner interacts with Kubernetes by watching PVCs and
+PVs and implementing the [external provisioner
+protocol](https://github.com/kubernetes/community/blob/master/contributors/design-proposals/storage/container-storage-interface.md#provisioning-and-deleting).
+The [design document](./docs/design.md) explains this in more detail.
+
 ### Topology support
 When `Topology` feature is enabled and the driver specifies `VOLUME_ACCESSIBILITY_CONSTRAINTS` in its plugin capabilities, external-provisioner prepares `CreateVolumeRequest.AccessibilityRequirements` while calling `Controller.CreateVolume`. The driver has to consider these topology constraints while creating the volume. Below table shows how these `AccessibilityRequirements` are prepared:
 

doc/design.md

@@ -0,0 +1,27 @@
+# Design
+
+External-provisioner interacts with Kubernetes by watching PVCs and
+PVs and implementing the [external provisioner
+protocol](https://github.com/kubernetes/community/blob/master/contributors/design-proposals/storage/container-storage-interface.md#provisioning-and-deleting).
+The following diagram illustrates that, starting with the creation of
+a PVC by a user and ending with the removal of all resources.
+
+![](provisioning.png)
+
+When an object is marked for deletion, actual deletion is delayed
+until the controller checks the necessary preconditions for deletion
+and removes its finalizer.
+
+Failures are handled by retrying, which is only shown here for
+`CreateVolume` calls because it is a bit special: for late binding, a
+CSI driver can trigger the re-scheduling of a pod by returning the
+special `ResourceExhausted` gRPC status code.
+
+Note that a timed-out `CreateVolume` call does not change any state
+and will simply get repeated. If the CSI driver has completed volume
+creation in the meantime, it must recognize the repeated call and
+return information about it ("idempotency"). All gRPC calls have to be
+idempotent.
+
+How the selected node is communicated to the CSI driver is explained
+in the [topology](../README.md#topology-support) section.

doc/doc.make

@@ -0,0 +1,13 @@
+# We use the http://plantuml.com/plantuml server to generate
+# images. That way nothing needs to be installed besides Go.
+# The client tool has no license, so we can't vendor it.
+# Instead we "go get" it if (and only if) needed.
+DOC_PLANTUML_GO = $(shell go env GOPATH)/bin/plantuml-go
+
+%.png: %.puml $(DOC_PLANTUML_GO)
+	$(DOC_PLANTUML_GO) -format png $<
+
+# Builds the binary in GOPATH/bin. Changing into / first avoids
+# modifying the project's go.mod file.
+$(DOC_PLANTUML_GO):
+	cd / && go get github.com/acarlson99/plantuml-go

doc/provisioning.puml

@@ -0,0 +1,32 @@
+@startuml
+(*) -->[ **user** creates PVC ] "PVC exists"
+-->[ **PV controller** checks storage class and existing PVs ] ==B1==
+
+==B1== -->[= __immediate binding:__\lif necessary, **PV controller** sets the\l""volume.beta.kubernetes.io/storage-provisioner""\lannotation] "PVC ready for provisioning" as PVC_READY_IMMEDIATE
+  -->"CreateVolume for all nodes" as CREATE_VOLUME_ALL
+  -->[failure] "PVC_READY_IMMEDIATE"
+  CREATE_VOLUME_ALL -->[success] ==B2==
+
+==B1== -->[= __late binding__] "wait for pod" as POD
+  -->[ **scheduler** tentatively chooses a node for the pod\lwhich uses the volume and sets the\l""volume.beta.kubernetes.io/selected-node""\lannotation ] "PVC with selected node" as PVC_SELECTED
+  -->[if necessary, **PV controller** sets the\l""volume.beta.kubernetes.io/storage-provisioner""\lannotation ] "PVC with selected node ready for provisioning" as PVC_SELECTED_READY
+  --> "CreateVolume for selected node" as CREATE_VOLUME_SELECTED
+  -->[""ResourceExhausted"":\l**external-provisioner**\lunsets the\l""selected-node"" annotation] "POD"
+  CREATE_VOLUME_SELECTED -->[failure] "PVC_SELECTED_READY"
+  CREATE_VOLUME_SELECTED -->[success] ==B2==
+
+==B2== --> "volume exists" as VOLUME_EXISTS
+-->[ **external-provisioner** creates PV ] "PV ready for binding"
+-->[ **PV controller** sets\l* ""PV.Status.Phase: Bound"" ] "PV bound"
+-->[ **PV controller** sets\l* ""pv.kubernetes.io/bind-completed: yes""\l* ""pv.kubernetes.io/bound-by-controller: yes""\l* ""PVC.Spec.VolumeName""] "PVC almost bound"
+-->[ **PV controller** sets\l* ""PVC.Status.Phase: Bound""\l* ""PVC.Status.Capacity"" ] "PVC bound"
+-->[ **user** deletes PVC ] "PVC marked for deletion"
+-->[ **PVC protection controller** determines that PVC is not in use ] "PVC deleted, PV orphaned" as VOLUME_READY_FOR_DELETION
+--> "DeleteVolume"
+DeleteVolume -->[failure] VOLUME_READY_FOR_DELETION
+DeleteVolume -->[success] "volume deleted"
+-->[ **external-provisioner** set ""PV.Status.Phase: Released"" ] "PV ready for deletion" as PV_READY_FOR_DELETION
+-->[ **external-provisioner** deletes PV ] "PV marked for deletion"
+-->[ **PV controller** checks the volume one last time\l and removes the pv protection finalizer ] "PV deleted"
+--> (*)
+@enduml